Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): Move schema check function from polars-stream to polars-io #18790

Closed
wants to merge 1 commit into from
Closed

refactor(rust): Move schema check function from polars-stream to polars-io #18790

wants to merge 1 commit into from

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 17, 2024 •
edited
Loading

Preparation for supporting reading list of parquet files with different physical column orders.

nvm, we can't re-use this

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (f631502) to head (2c7ec67).

Files with missing lines Patch % Lines
crates/polars-io/src/parquet/read/utils.rs 0.00% 24 Missing ⚠️
...-stream/src/nodes/parquet_source/metadata_utils.rs 0.00% 2 Missing ⚠️
...-stream/src/nodes/parquet_source/metadata_fetch.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #18790   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files        1518     1518           
  Lines      205567   205574    +7     
  Branches     2892     2892           
=======================================
+ Hits       164124   164137   +13     
+ Misses      40895    40889    -6     
  Partials      548      548

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion deleted the move-schema-check-func branch September 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nameexhaustion